Task framework #2275
Draft
Task framework #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test task is working with the system, no obvious errors
- added task weights - cached task params
killerswin2
suggested changes
Mar 7, 2022
|
I don't understand why you are making tasks a separate pbo. The task are deep ingrained into core, so why not place in core? |
killerswin2
suggested changes
Mar 7, 2022
killerswin2
suggested changes
Mar 7, 2022
(uses standard requiredAddons syntax in config)
killerswin2
suggested changes
Apr 2, 2022
killerswin2
suggested changes
Apr 2, 2022
Lazejun
reviewed
Apr 3, 2022
- corrected incorrect site pool for as_official
…marker-type destinations
Fix some task destination bugs
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
rautamiekka
reviewed
Mar 18, 2023
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
killerswin2
reviewed
Mar 19, 2023
Co-authored-by: Ellis Nielsen <thecakebecamethelie@yahoo.com>
Bob-Murphy
requested changes
Mar 22, 2023
| }; | ||
| if (((_this get "state") isEqualTo "SUCCEEDED") and (not alive (_this get "truckX"))) then | ||
| { | ||
| [petros,"hint",(localize "STR_antistasi_LTasks_LOG_Ammo_destroyed_description"), "Logistics Mission"] remoteExec ["A3A_fnc_commsMP",[teamPlayer,civilian]]; |
There was a problem hiding this comment.
"Logistics Mission"
Please localize
| // OKAY TASK IS GOOD | ||
| if (((_this get "state") isEqualTo "SUCCEEDED") and (alive (_this get "truckX"))) then | ||
| { | ||
| [petros,"hint",(localize "STR_antistasi_LTasks_LOG_Ammo_captured"), "Logistics Mission"] remoteExec ["A3A_fnc_commsMP",[teamPlayer,civilian]]; |
There was a problem hiding this comment.
"Logistics Mission"
Please localize
| private _owningSide = (_vehicle getVariable "originalSide"); // set by AIVEHinit | ||
|
|
||
| if (_unit getVariable ["spawner",false]) then { | ||
| ["TaskFailed", ["", format ["Ammotruck Stolen in an %1",(_vehicle getVariable ["ammoTruckLocation", ""])]]] remoteExec ["BIS_fnc_showNotification",_owningSide]; |
There was a problem hiding this comment.
"Ammotruck Stolen in an %1"
Please localize
| // OKAY TASK IS GOOD | ||
| if ((_this get "state") isEqualTo "SUCCEEDED") then | ||
| { | ||
| [petros,"hint",(localize "STR_antistasi_LTasks_LOG_Supplies_supplies_delivered"), "Logistics Mission"] remoteExec ["A3A_fnc_commsMP",[teamPlayer,civilian]]; |
There was a problem hiding this comment.
"Logistics Mission"
Please localize
| </Key> | ||
| <Key ID="STR_antistasi_LTasks_AS_specOP_description"> | ||
| <!-- %1 = Faction name | %2 = Location name | %3 = time in format H:M --> | ||
| <Original>We have spotted a %1 SpecOp team patrolling around a %2. Ambush them and we will have one less problem. Do this before %3. Be careful, they are tough boys.</Original> |
There was a problem hiding this comment.
Just double-checking, does it makes to have the a before the %2?
It is stating something like "ourpost, airport, resource" or for example a city name?
Maybe around the would be more fitting as for outpost/airport it would be an outpost / an airfield.
| </Key> | ||
| <!-- %1 = Location name | %2 = time in format H:M --> | ||
| <Key ID="STR_antistasi_LTasks_CON_Outpost_resource_description"> | ||
| <Original>A %1 would be a fine addition to our cause. Go there and capture it before %2.</Original> |
There was a problem hiding this comment.
Same here, what exactly is the location name? Does the A make sense?
| </Key> | ||
| <!-- %1 = Location name | %2 = time in format H:M --> | ||
| <Key ID="STR_antistasi_LTasks_CON_Outpost_outpost_description"> | ||
| <Original>A %1 is disturbing our operations in the area. Go there and capture it before %2.</Original> |
| <Original>City Supplies</Original> | ||
| </Key> | ||
| <Key ID="STR_antistasi_LTasks_LOG_Supplies_description"> | ||
| <Original>%1 population is in need of supplies. We may improve our relationship with that city if we are the ones who provide them. I have placed a crate with supplies near our HQ. Deliver the crate to %1 city center, hold it there for %3 minutes and it's done. Do this before %2.</Original> |
There was a problem hiding this comment.
You mention city center but we mostly deliver to villages.
Maybe something like Deliver the crate to the center of %1 makes more sense.
| <Original>%1 population is in need of supplies. We may improve our relationship with that city if we are the ones who provide them. I have placed a crate with supplies near our HQ. Deliver the crate to %1 city center, hold it there for %3 minutes and it's done. Do this before %2.</Original> | ||
| </Key> | ||
| <Key ID="STR_antistasi_LTasks_LOG_Supplies_distributing_supplies"> | ||
| <Original>Keep distributing supplies for %1 more seconds.</Original> |
There was a problem hiding this comment.
You are not actively distributing the supplies but more guarding them.
Keep guarding the supplies for %1 more seconds.
| <Original>Steal or Destroy Ammotruck</Original> | ||
| </Key> | ||
| <Key ID="STR_antistasi_LTasks_LOG_Ammo_description"> | ||
| <Original>We've spotted an Ammotruck in an %1. Go there and destroy or steal it before %2.%2.</Original> |
- added comments to make the proccess more readable - minor code readability improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Information:
New task framework (WIP)
Please specify which Issue this PR Resolves.
closes #XXXX
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
Notes:
System design open for major changes to correct shortcomings
Only a test task exists and the old task should be converted over to act as a temporary source of tasks until new task can be written (new task will be a resource heavy process)