Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task framework #2275

Draft
wants to merge 56 commits into
base: unstable
Choose a base branch
from

Conversation

HakonRydland
Copy link
Collaborator

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Information:
New task framework (WIP)

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

Steps:


Notes:

  • 03.March
    System design open for major changes to correct shortcomings
    Only a test task exists and the old task should be converted over to act as a temporary source of tasks until new task can be written (new task will be a resource heavy process)

Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

A3A/addons/Tasks/Core/fn_getSettings.sqf Outdated Show resolved Hide resolved
A3A/addons/Tasks/Core/fn_getSettings.sqf Outdated Show resolved Hide resolved
A3A/addons/Tasks/Core/fn_requestTask.sqf Outdated Show resolved Hide resolved
A3A/addons/Tasks/Core/fn_requestTask.sqf Outdated Show resolved Hide resolved
A3A/addons/Tasks/Core/fn_genTaskID.sqf Outdated Show resolved Hide resolved
A3A/addons/Tasks/Core/fn_getSettings.sqf Outdated Show resolved Hide resolved
@killerswin2
Copy link

I don't understand why you are making tasks a separate pbo. The task are deep ingrained into core, so why not place in core?

HakonRydland and others added 8 commits March 18, 2023 09:22
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Jouni Järvinen <rautamiekka@users.noreply.github.com>
Co-authored-by: Ellis Nielsen <thecakebecamethelie@yahoo.com>
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as noted

};
if (((_this get "state") isEqualTo "SUCCEEDED") and (not alive (_this get "truckX"))) then
{
[petros,"hint",(localize "STR_antistasi_LTasks_LOG_Ammo_destroyed_description"), "Logistics Mission"] remoteExec ["A3A_fnc_commsMP",[teamPlayer,civilian]];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Logistics Mission"
Please localize

// OKAY TASK IS GOOD
if (((_this get "state") isEqualTo "SUCCEEDED") and (alive (_this get "truckX"))) then
{
[petros,"hint",(localize "STR_antistasi_LTasks_LOG_Ammo_captured"), "Logistics Mission"] remoteExec ["A3A_fnc_commsMP",[teamPlayer,civilian]];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Logistics Mission"
Please localize

private _owningSide = (_vehicle getVariable "originalSide"); // set by AIVEHinit

if (_unit getVariable ["spawner",false]) then {
["TaskFailed", ["", format ["Ammotruck Stolen in an %1",(_vehicle getVariable ["ammoTruckLocation", ""])]]] remoteExec ["BIS_fnc_showNotification",_owningSide];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ammotruck Stolen in an %1"
Please localize

// OKAY TASK IS GOOD
if ((_this get "state") isEqualTo "SUCCEEDED") then
{
[petros,"hint",(localize "STR_antistasi_LTasks_LOG_Supplies_supplies_delivered"), "Logistics Mission"] remoteExec ["A3A_fnc_commsMP",[teamPlayer,civilian]];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Logistics Mission"
Please localize

</Key>
<Key ID="STR_antistasi_LTasks_AS_specOP_description">
<!-- %1 = Faction name | %2 = Location name | %3 = time in format H:M -->
<Original>We have spotted a %1 SpecOp team patrolling around a %2. Ambush them and we will have one less problem. Do this before %3. Be careful, they are tough boys.</Original>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checking, does it makes to have the a before the %2?
It is stating something like "ourpost, airport, resource" or for example a city name?
Maybe around the would be more fitting as for outpost/airport it would be an outpost / an airfield.

</Key>
<!-- %1 = Location name | %2 = time in format H:M -->
<Key ID="STR_antistasi_LTasks_CON_Outpost_resource_description">
<Original>A %1 would be a fine addition to our cause. Go there and capture it before %2.</Original>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, what exactly is the location name? Does the A make sense?

</Key>
<!-- %1 = Location name | %2 = time in format H:M -->
<Key ID="STR_antistasi_LTasks_CON_Outpost_outpost_description">
<Original>A %1 is disturbing our operations in the area. Go there and capture it before %2.</Original>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

<Original>City Supplies</Original>
</Key>
<Key ID="STR_antistasi_LTasks_LOG_Supplies_description">
<Original>%1 population is in need of supplies. We may improve our relationship with that city if we are the ones who provide them. I have placed a crate with supplies near our HQ. Deliver the crate to %1 city center, hold it there for %3 minutes and it's done. Do this before %2.</Original>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mention city center but we mostly deliver to villages.
Maybe something like Deliver the crate to the center of %1 makes more sense.

<Original>%1 population is in need of supplies. We may improve our relationship with that city if we are the ones who provide them. I have placed a crate with supplies near our HQ. Deliver the crate to %1 city center, hold it there for %3 minutes and it's done. Do this before %2.</Original>
</Key>
<Key ID="STR_antistasi_LTasks_LOG_Supplies_distributing_supplies">
<Original>Keep distributing supplies for %1 more seconds.</Original>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not actively distributing the supplies but more guarding them.
Keep guarding the supplies for %1 more seconds.

<Original>Steal or Destroy Ammotruck</Original>
</Key>
<Key ID="STR_antistasi_LTasks_LOG_Ammo_description">
<Original>We've spotted an Ammotruck in an %1. Go there and destroy or steal it before %2.%2.</Original>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplication of %2?

- added comments to make the proccess more readable
- minor code readability improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants