Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve garage source checking #2860

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Jul 26, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Rewrote the garage source checker functions. The only intentional logic change is that the vanilla source data is checked regardless of whether ACE is loaded. This means that mod vehicles with missing or incomplete ACE compats will now work correctly.

Tested all six code paths with and without ACE, on repair, ammo and fuel vehicles. Seems fine.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

@jaj22 jaj22 added the Change A change to existing functionality label Jul 26, 2023
@jaj22 jaj22 added this to the 3.4 milestone Jul 26, 2023
Copy link

@MeltedPixel MeltedPixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, looks good!

@Bob-Murphy Bob-Murphy merged commit 9f9928a into official-antistasi-community:unstable Aug 9, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Change A change to existing functionality Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants