Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rebel AI to use rifle+muzzle combo grenade launchers #2899

Merged

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Aug 3, 2023

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

Rebel AI can't use the SPE grenade launcher rifles because they're broken down into base weapons when adding them to the arsenal. This PR searches categoryOverrides for suitable weapons and adds them in generateRebelGear when you have sufficient rifles and muzzles.

Probably a bit too dangerous for 3.3.3 because it has a small risk of causing issues in other modsets.

Please specify which Issue this PR Resolves.

closes #2897

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

Check if it does anything weird in other modsets.

How can the changes be tested?

After startup you can check the value of A3A_specialGrenadeLaunchers for weird shit. It's a hashmap with GL rifle classes as keys and [baseweapon, muzzle] values.

@jaj22 jaj22 added the Enhancement New feature or request label Aug 3, 2023
@jaj22 jaj22 added this to the 3.4 milestone Aug 3, 2023
Copy link

@MeltedPixel MeltedPixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.
Tests: Good.

@Bob-Murphy Bob-Murphy merged commit c64f9f3 into official-antistasi-community:unstable Aug 9, 2023
@Bob-Murphy Bob-Murphy added the Added to changelog Added to changelog label Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added to changelog Added to changelog Enhancement New feature or request Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ugh mods]: Rebel AIs can't take SPE grenade launchers
4 participants