English Stringtable Update #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bob-Murphy
requested changes
Nov 18, 2023
|
Fixed. Are 860 and 886 just for consistency? |
It's fun, known and already translated. No real need to change it. |
Bob-Murphy
requested changes
Nov 18, 2023
Bob-Murphy
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
Information:
A lot of changes to addons/core/Stringtable.xml to improve clarity and grammar errors in certain places. Beyond a few specific grammar errors or typos, most of the changes were left to my purview and I've attempted to make them clearer for new players to understand. Let me know about any changes you think are necessary.
Please specify which Issue this PR Resolves.
closes #3046
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
Steps:
All of the "problematic strings"' have been tested (e.g. strings with specific formatting and breaks in them), the only strings left are the strings relating to Garbage Cleaning, members, and FF punishments because those aren't things I can test on a LAN host and I am far too smooth brain to go through the effort of setting up a dedicated server to test basic changes to strings.
Notes: