Fix SoldierGB inheritance chain for CBA XEH. Probably. #3381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this.
What have you changed and why?
#3377 broke the CBA XEH event handlers for SoldierGB onwards, I guess because CBA works around the broken inheritance by selectively spamming the event handlers into various places, and our new inheritance chain didn't touch any of those. Fixing the link from SoldierGB -> CAManBase seems to work, although I'm not 100% sure that I've tested both load orders. Because our config doesn't have a dependency on CBA, it's possible for CBA to be loaded either before or after. Either way it's better than it was, but we might need to handle the inheritance patch differently.
Please specify which Issue this PR Resolves.
closes #XXXX
Please verify the following and ensure all checks are completed.
Is further testing or are further changes required?
How can the changes be tested?
I don't know.