Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SoldierGB inheritance chain for CBA XEH. Probably. #3381

Merged

Conversation

jaj22
Copy link

@jaj22 jaj22 commented Aug 18, 2024

What type of PR is this.

  1. Bug
  2. Change
  3. Enhancement

What have you changed and why?

#3377 broke the CBA XEH event handlers for SoldierGB onwards, I guess because CBA works around the broken inheritance by selectively spamming the event handlers into various places, and our new inheritance chain didn't touch any of those. Fixing the link from SoldierGB -> CAManBase seems to work, although I'm not 100% sure that I've tested both load orders. Because our config doesn't have a dependency on CBA, it's possible for CBA to be loaded either before or after. Either way it's better than it was, but we might need to handle the inheritance patch differently.

Please specify which Issue this PR Resolves.

closes #XXXX

Please verify the following and ensure all checks are completed.

  1. Have you loaded the mission in LAN host?
  2. Have you loaded the mission on a dedicated server?

Is further testing or are further changes required?

  1. No
  2. Yes (Please provide further detail below.)

How can the changes be tested?

I don't know.

@jaj22 jaj22 added the Bug Something isn't working label Aug 18, 2024
Copy link

@Bob-Murphy Bob-Murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works

@Bob-Murphy Bob-Murphy added this to the 3.7 milestone Aug 18, 2024
@Bob-Murphy Bob-Murphy merged commit f115593 into official-antistasi-community:unstable Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants