-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce session objects #2115
base: master
Are you sure you want to change the base?
Conversation
The fishtest remote is handled with a session object, which allows one to persist parameters between requests, and in particular to maintain tcp connections.
I think this is too related to the password hashing problem, you can login once and keep reusing the session. |
The primary purpose of the PR is to improve performance, i.e. ensure connections to the server are persistent. This is also working, but we would need to understand if there is a disadvantage to configuring the server such that it has 10k+ persistent open connections (we know how, but not if it is a good idea.) That's actually a question @noobpwnftw might be able to answer. |
Apart from that, I agree that it could be used to store tokens and change authentication. But it is a separate topic that would need further work. |
Probably can also close the session in case graceful shutdown with |
It is generally not a good idea to have too many persistent connections especially when there is a proxy on the same box. OTOH, the client side |
The fishtest remote is handled with a session object, which allows one to persist parameters between requests, and in particular to maintain tcp connections.