Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing the maximum number of tests users can follow from 15 to 20 #2118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FauziAkram
Copy link
Contributor

Increasing the maximum number of tests users can follow from 15 to 20.
So users can keep track of more tests simultaneously, allowing for a more comprehensive overview of ongoing tests.
Also, the previous limit of 15 was arbitrary, and increasing the limit poses no risks. This adjustment aligns with user needs for better monitoring and management of tests.

P.s: The new limit of 20 is also an arbitrary number, but it is better than before, and from my point of view is enough to satisfy users activity. But the limit can be increased further if needed.

@FauziAkram
Copy link
Contributor Author

@ppigazzini are there any drawbacks to increasing the limit?

@FauziAkram
Copy link
Contributor Author

FauziAkram commented Aug 12, 2024

Why is it taking so long to resolve this PR?
In this period, around 35-60 active tests are running in fishtest, being able to follow only 15 at a time is very limiting, as a user I would prefer to be able to follow more than that.

@Disservin
Copy link
Member

well if you take a look at the commits the last commit was on Jul 6, 2024... so it's no surprise there's no feedback on this + this is just a temporary solution to a permanent problem..
there's no good reason why this should be 20 especially when you say 35-60 tests are active... the proper way would be just to rewrite this bit and not use a capped container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants