Replace lookup-controller util with Route#controllerFor #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in `/utils/lookup-controller.js` seems to be roughly the same that is already implemented in [Route#controllerFor](https://emberjs.com/api/ember/2.15/classes/Ember.Route/methods/controllerFor?anchor=controllerFor). Additionally, this seems to fix a bug that I was running into when trying to use this addon inside of an engine with `factoryFor` not being defined.
|
@HeroicEric the reason we do not use Is there a reason why |
|
Closing as this PR has been abandoned. Feel free to reopen if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lookup-controllerutility with calls toRoute#controllerForember-getowner-polyfillbe removed.The logic in
/utils/lookup-controller.jsseems to be roughly the same that isalready implemented in Route#controllerFor.
Additionally, this seems to fix a bug that I was running into when
trying to use this addon inside of an engine with
factoryFornot beingdefined.
Any reason the special util was being used instead of
Route#controllerFor?