Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 72 #75

Merged
merged 1 commit into from Feb 27, 2019
Merged

fix 72 #75

merged 1 commit into from Feb 27, 2019

Conversation

ghost
Copy link

@ghost ghost commented Feb 25, 2019

My only hesitation with this fix is how defining toString on this mixin will impact consuming applications. For example, if an app uses toString for introspection on a controller extending the QueryParams mixin, will it just return Parachute?
I tried toStringExtensions and that preserved the class output, so maybe I should define that: https://emberjs.com/api/ember/3.8/classes/CoreObject/methods/toString?anchor=toString

@offirgolan
Copy link
Owner

Im not a big fan of this either. Honestly, I say we just remove this altogether since NAME_KEY was used as a nice to have when debugging in the ember inspector.

@eflanagan0
fix 72
66cc74f 
Remove custom label to aid Ember Inspector users. We could override
toString as suggested by the deprecation guide, but that introduces
other problems we don't want to manage here.
@ghost
Copy link
Author

ghost commented Feb 27, 2019

@offirgolan agreed. Updated to remove.

@offirgolan offirgolan merged commit 415d080 into offirgolan:master Feb 27, 2019
@ghost ghost deleted the fix-72 branch February 27, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@offirgolan @eflanagan0