fix: remove empty default hooks from QueryParams
#76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the order that the `queryParams` mixin is applied, `queryParamsDidChange`, `setup`, and `reset` are not overrideable by methods in the controller. The issue is visible on the [demo page](https://offirgolan.github.io/ember-parachute/); the progress bar that is supposed to appear on top of the form on `queryParamsDidChange` never shows up. Removing the empty placeholder methods allows them to be defined in the controller, and they still work without being overriden because they are always called with `tryInvoke`.
|
@ckbaum thanks for this PR! The build seems to be failing on your new test case. |
|
Resolved in #79. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the order that the
queryParamsmixin is applied,queryParamsDidChange,setup, andresetare not overrideable by methods in the controller.The issue is visible on the demo page; the progress bar that is supposed to appear on top of the form on
queryParamsDidChangenever shows up.Removing the empty placeholder methods allows them to be defined in the controller, and they still work without being overriden because they are always called with
tryInvoke.