Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python3.4 And Add Python3.8 #508

Merged
merged 3 commits into from
Nov 16, 2019
Merged

Remove Python3.4 And Add Python3.8 #508

merged 3 commits into from
Nov 16, 2019

Conversation

helloqiu
Copy link
Collaborator

@helloqiu helloqiu commented Nov 15, 2019

close #507

@helloqiu helloqiu requested a review from whtsky November 15, 2019 21:53
@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #508 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage   90.46%   90.55%   +0.09%     
==========================================
  Files          28       28              
  Lines        1437     1451      +14     
==========================================
+ Hits         1300     1314      +14     
  Misses        137      137
Impacted Files Coverage Δ
werobot/messages/messages.py 100% <0%> (ø) ⬆️
werobot/contrib/django.py 100% <0%> (ø) ⬆️
werobot/utils.py 100% <0%> (ø) ⬆️
werobot/replies.py 100% <0%> (ø) ⬆️
werobot/client.py 98.07% <0%> (+0.03%) ⬆️
werobot/robot.py 87.54% <0%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1024218...e26cbff. Read the comment docs.

@helloqiu helloqiu changed the title Remove Python3.4 Remove Python3.4 And Add Python3.8 Nov 15, 2019
@helloqiu
Copy link
Collaborator Author

tornadoweb/tornado#2608

@TravisBuddy
Copy link

Hey @helloqiu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c3171200-0801-11ea-a7d8-2f45f8a3b8c0

@whtsky whtsky merged commit 0178b74 into master Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python3.4 is Deprecated
3 participants