-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report number of registrations required/supported by domain #3084
Comments
I like this idea. Is this something reported back to the application during the fi_getinfo inquiry by the application? |
Yes - I was thinking of just adding a new domain attribute field. The change is fairly small, but should be done before 1.5 is released to save another api churn.
|
Is it going to be something that is only returned from providers, or will it be a 'in' parameter as part of hints? If it is part of the hints, I imagine providers would need to return -ENODATA if they cannot support the number of registrations requested in the hints. |
I believe it should work as an in parameter as well. Maybe the provider can optimize if it knew how many regions the app needed?
|
I think in some cases that might be true. I know that the GNI provider has limitations on the number of registrations depending on the memory registration mode, which could be affected by this change (really only affects what number gets reported). I think if providers use a user-space level cache, it can help to reduce memory consumption if much of the space used would be wasted without the knowledge of how many registrations an application needed. It does pose an interesting question. I don't know that this applies to other providers, but the number of available keys is dependent on the memory model being used, and for the GNI provider, that is associated with the domain (but really tied to the [hardware]protection key/[libfabric]authorization key). Does it make sense to report the number of memory registrations that can be associated with a particular authorization key? I realize that the GNI provider may one of a few (or the only) provider(s) that tie memory registration to the hardware level protection constructs through the libfabric authorization key. |
Fixes ofiwg#3084 Allow the provider to indicate the number of memory registrations that it can support on a domain. This also allows the app a way to indicate how many memory regions it may need. Providers can use this value to optimize caching of registrations. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
See PR #3105 -- all providers will need to be updated. That will be a separate set of PRs. |
Fixes ofiwg#3084 Allow the provider to indicate the number of memory registrations that it can support on a domain. This also allows the app a way to indicate how many memory regions it may need. Providers can use this value to optimize caching of registrations. Add missing output to fi_tostr as part of adding mr_cnt Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Fixes ofiwg#3084 Allow the provider to indicate the number of memory registrations that it can support on a domain. This also allows the app a way to indicate how many memory regions it may need. Providers can use this value to optimize caching of registrations. Add missing output to fi_tostr as part of adding mr_cnt Change-Id: Id1f6f17ad67c89741137a72cead380101ee56dc8 Signed-off-by: Sean Hefty <sean.hefty@intel.com> Signed-off-by: Dmitry Gladkov <dmitry.gladkov@intel.com>
Fixes ofiwg#3084 Allow the provider to indicate the number of memory registrations that it can support on a domain. This also allows the app a way to indicate how many memory regions it may need. Providers can use this value to optimize caching of registrations. Add missing output to fi_tostr as part of adding mr_cnt Signed-off-by: Sean Hefty <sean.hefty@intel.com> Signed-off-by: Dmitry Gladkov <dmitry.gladkov@intel.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
per ofiwg#3084. Signed-off-by: Thananon Patinyasakdikul <apatinya@cisco.com>
Add mr_cnt field to domain_attr, to indicate how many MRs are supported by this domain. This is a small change to the domain attribute, but would need to be fit in prior to the 1.5 release, since it updates the API.
The text was updated successfully, but these errors were encountered: