prov/lpp: add check for atomics #10651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpp includes stdatomic.h but does not include a check for it in the configure so can cause a build to fail on a system without it Signed-off-by: Alexia Ingerson <alexia.ingerson@intel.com>
|
@tstruk noticed this config issue, please take a look and see if that's ok with you or if you want to add a more appropriate check/implementation that doesn't require atomics |
|
@aingerson LGTM thanks |
|
@shijin-aws Can you confirm that the AWS error is unrelated? |
|
@aingerson unrelated infrastructure error. Can ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lpp includes stdatomic.h but does not include a check for it in the configure so can cause a build to fail on a system without it