prov/efa: Remove inline write logic for efa_rma inject #10679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
reviewed
Jan 6, 2025
| #else | ||
| /* MSVC compiler does not support array declarations with runtime size, so hardcode | ||
| * the expected iov_limit/max_sq_sge from the lower-level efa provider. | ||
| */ | ||
| struct ibv_sge sge_list[EFA_DEV_ATTR_MAX_WR_SGE]; | ||
| struct ibv_data_buf inline_data_list[EFA_DEV_ATTR_MAX_WR_SGE]; | ||
| #endif | ||
| size_t len; | ||
| int i, err = 0; | ||
|
|
There was a problem hiding this comment.
You also need to raise error when flags has FI_INJECT
There was a problem hiding this comment.
Also add a unit test for it.
jiaxiyan
force-pushed
the
inline_write
branch
2 times, most recently
from
906e465 to
80455a5
Compare
shijin-aws
changed the title
shijin-aws
previously approved these changes
Jan 7, 2025
|
need to resolve the merge conflict |
We previously set the inject size to 0 to prevent using inline write, but fabtests can use inject rma for 0 size message. Make rma inject temporarily return FI_ENOSYS before firmware supports inline write. Signed-off-by: Jessie Yang <jiaxiyan@amazon.com>
shijin-aws
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously set the inject size to 0 to prevent using inline write, but application can use inject rma for 0 size message. Make rma inject temporarily return FI_ENOSYS before firmware supports inline write.