cherry picked commits for minor issues #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the default call to fi_no_bind, rather than leaving null. This avoids a potential null deref, as seen when running fi_multi_mr test over the rxd provider with udp. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Error path called free on an mmapped region. Added a check to unmap instead. Signed-off-by: William Zhang <wilzhang@amazon.com> Signed-off-by: Raghu Raja <craghun@amazon.com> Signed-off-by: Sean Hefty <sean.hefty@intel.com>
rajachan
approved these changes
Jun 10, 2019
|
@rajachan - you approved this, but github didn't count that as an approving review for some reason in order to merge this, so I requested your review. |
rajachan
approved these changes
Jun 10, 2019
|
"Only reviews by reviewers with write access count toward mergeability". Guess I am not part of the club. |
|
@rajachan - I added you as a writer, assuming that you'll be updating EFA long term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid segfault when calling fi_mr_bind() and fix cleanup in util_buf wrt huge pages.