prov/rxm: fixes to handling completion errors #6707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The emulated inject path sets the hdr.state to TX. This can result in the completion being reported to the application. Use the INJECT_TX state instead, so we can trap for the completion and discard it. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Remove duplicate setting of the hdr.state and unnecessary progress call. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Do not generate CQ entries that are returned to the application for transfers that are associated with internal sends. Provide error handling for missing transfer states. To prepare this patch a full analysis of the rxm tx/rx states was done. Minor code cleanups occur around the state handling locations. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
ooststep
reviewed
Apr 22, 2021
When establishing a loopback connection, it's possible for the rxm_cmap_handle fi_addr and peer fields to both be valid. However, the rxm_conn_handle_notify() path assumes that only one is valid. The result is that the cmap->handles_av[] can be left with a stale entry referencing a freed handle. Check to see if the handle's fi_addr is valid directly and remove it from the av prior to freeing the handle. Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are based on a code inspection of the states for tx operations. For transfers generated for internal protocol operations, discard all completions. Do not report failures to the application, which lacks any context for the operation. Add completion error handling for missing states. In a couple of cases, mark bugs in the state machine where races impact error handling (affects write rendezvous and atomics).
Most of these changes impact the processing of transfers that complete in error. As a result, testing the changes is difficult.