prov/rxm: minor fixes to connection management #6953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aingerson
reviewed
Jul 27, 2021
j-xiong
approved these changes
Jul 29, 2021
|
The "merge" commit looks suspicious. Need a local rebase first? |
loopback connections are not necessarily indexed in the destination, so trak them so that we can properly clean them up when we shut down. Signed-off-by: Stephen Oost <stephen.oost@intel.com>
Signed-off-by: Stephen Oost <stephen.oost@intel.com>
The address comparison to determine whether to reject or keep a duplicate connection was incorrect and falsely identifying too many loopback connections. The address to compare against should be the local EP's address, not the peer's address. This fix exposes an issue with the reject/close path which was not being taken before. A race condition during simultaneous connections was occurring where both sides sent a connection request. One side received a connection request, accepted, and closed its outgoing connection. However, the connection request had already been received by the peer, causing the peer to incorrectly identify that connection as a lost connection, causing send failures for any outstanding sends on that active connection. This patch could potentially cause issues in how lost connections are managed, but testing to date has not shown any issues... yet... Signed-off-by: aingerson <alexia.ingerson@intel.com>
If the error entry is not initialized, the core provider may try to save into err_data if err_data_size is set to a bogus value indicating there is space when there is not. Signed-off-by: Stephen Oost <stephen.oost@intel.com> Signed-off-by: aingerson <alexia.ingerson@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, address an issue where we weren't comparing the correct address structure (thanks @aingerson)
This exposed an issue, which causes problems at shut down, in loopback tracking and clean up. We were losing track of the recipient side of a loopback connection and not closing and releasing them as we should have been.