prov/efa: fix bug in error handling in efa_device_construct() #7806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijin-aws
approved these changes
Jun 6, 2022
|
@wzamazon How can we test this bug fix? |
|
I am writing a unit test that mock |
wzamazon
force-pushed
the
efa_fix_error_handling_in_open_device
branch
from
1a3cfcf to
0fd10cd
Compare
|
@shijin-aws I added a commit to include a unit test that mimic original bug, please review again. |
shijin-aws
reviewed
Jun 7, 2022
| efa_device_construct(&efa_device, 0, ibv_device_list[0]); | ||
|
|
||
| /* when error happend, efa_device.ibv_ctx should be NULL */ | ||
| assert_null(efa_device.ibv_ctx); |
There was a problem hiding this comment.
why not we check efa_device->rdm_info and efa_device->dgram_info as well?
There was a problem hiding this comment.
make sense. added in new revision.
This patch added a unit test for the error handling of function efa_device_construct(), this is to reproduce the GitHub issue: ofiwg#7805 Signed-off-by: Wei Zhang <wzam@amazon.com>
In function efa_device_construct()'s error handling path, resources (like ibv_ctx) were released, but the pointer was not reset to NULL, which can caused double free. This patch addressed the issue. Signed-off-by: Wei Zhang <wzam@amazon.com>
wzamazon
force-pushed
the
efa_fix_error_handling_in_open_device
branch
from
0fd10cd to
65eff4f
Compare
shijin-aws
approved these changes
Jun 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In function efa_device_construct()'s error handling path, resources
(like ibv_ctx) were released, but the pointer was not reset to NULL,
which can caused double free. This patch addressed the issue.
Signed-off-by: Wei Zhang wzam@amazon.com