prov/efa: Use SHM's full inject size #9511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were subtracting EFA max header size from SHM inject size. Now that we use SHM as a peer provider, we can use SHM's full inject size of 4096. Also cleanup old deprecated env variable, and move hard coded value in place. Signed-off-by: Seth Zegelstein <szegel@amazon.com>
wenduwan
approved these changes
Nov 3, 2023
sunkuamzn
approved these changes
Nov 3, 2023
j-xiong
reviewed
Nov 3, 2023
| @@ -647,14 +647,15 @@ int efa_prov_info_alloc_for_rdm(struct fi_info **prov_info_rdm_ptr, | |||
| * pkt_entry_size - maximum_header_size. | |||
| */ | |||
| if (efa_env.enable_shm_transfer) | |||
| min_pkt_size = MIN(device->rdm_info->ep_attr->max_msg_size, efa_env.shm_max_medium_size); | |||
| min_pkt_size = MIN(device->rdm_info->ep_attr->max_msg_size - efa_rdm_pkt_type_get_max_hdr_size(), | |||
There was a problem hiding this comment.
The EFA provider has historically not enforced line length.
| else | ||
| min_pkt_size = device->rdm_info->ep_attr->max_msg_size; | ||
| min_pkt_size = device->rdm_info->ep_attr->max_msg_size - efa_rdm_pkt_type_get_max_hdr_size(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were subtracting EFA max header size from SHM inject size. Now that we use SHM as a peer provider, we can use SHM's full inject size of 4096. Also cleanup old deprecated env variable, and move hard coded value in place.