prov/efa: Fix the ibv cq error handling. #9652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenduwan
approved these changes
Dec 18, 2023
Comment on lines
473
to
477
| case IBV_WC_SEND: | ||
| #if ENABLE_DEBUG | ||
| if (opcode == IBV_WC_SEND) | ||
| ep->failed_send_comps++; | ||
| else | ||
| #endif | ||
| efa_rdm_pke_handle_tx_error(pkt_entry, FI_EIO, prov_errno); | ||
| break; | ||
| case IBV_WC_RDMA_WRITE: | ||
| #if ENABLE_DEBUG | ||
| ep->failed_write_comps++; | ||
| #endif | ||
| efa_rdm_pke_handle_tx_error(pkt_entry, FI_EIO, prov_errno); | ||
| } else { | ||
| assert(opcode == IBV_WC_RECV); | ||
| break; | ||
| case IBV_WC_RDMA_READ: | ||
| #if ENABLE_DEBUG | ||
| ep->failed_read_comps++; | ||
| #endif | ||
| efa_rdm_pke_handle_tx_error(pkt_entry, FI_EIO, prov_errno); | ||
| break; |
There was a problem hiding this comment.
nit we can also do fallthrough e.g.
case IBV_WC_SEND:
#if ENABLE_DEBUG
ep->failed_send_comps++;
#endif
case IBV_WC_RDMA_WRITE:
#if ENABLE_DEBUG
ep->failed_write_comps++;
#endif
case IBV_WC_RDMA_READ:
#if ENABLE_DEBUG
ep->failed_read_comps++;
#endif
efa_rdm_pke_handle_tx_error(pkt_entry, FI_EIO, prov_errno);
break;There was a problem hiding this comment.
doesn't that make failed_write_comps incremented for send as well?
There was a problem hiding this comment.
I see. The counter indeed introduces extra coding. We can find a more concise approach but I don't have a strong preference.
There was a problem hiding this comment.
yes, ideally we should declare failed_comps as an array, and have a map between the ibv wc code to the ofi op code, so we can increment the counter with the right index
There was a problem hiding this comment.
offline talked with @wenduwan, new revision removed the unused failed_send/write_comps to reduce the code duplication
Currently, efa_rdm_ep_poll_ibv_cq couldn't handle error for IBV_WC_RECV_RDMA_WITH_IMM and IBV_WC_RDMA_READ. This patch fixes it. It also removed the failed_send/write/read_comps in the debug build, because these symbols are never used. Signed-off-by: Shi Jin <sjina@amazon.com>
wenduwan
approved these changes
Dec 18, 2023
This was referenced Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, efa_rdm_ep_poll_ibv_cq couldn't
handle error for IBV_WC_RECV_RDMA_WITH_IMM
and IBV_WC_RDMA_READ. This patch fixes it.
It also removed the failed_send/write_comps
in the debug build, because these symbols
are never used.