Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fabtests/efa: Improve MR exhaustion test #9676

Merged
merged 3 commits into from
Dec 29, 2023

Conversation

sunkuamzn
Copy link
Contributor

Some improvements to the MR exhaustion test

  • Add a simple test for the unexpected message path
  • Get device MR limit by querying the device instead of hardcoding the value
  • Close ibv device after use

@wenduwan wenduwan requested a review from a team December 27, 2023 22:49
@a-szegel
Copy link
Contributor

Make sure to grab Wenduo's comment, also looks like there are some real fabtest failures here.

@sunkuamzn
Copy link
Contributor Author

bot:aws:retest

A simple implementation of the unexpected pingpong test that does not do
inject and only sends one unexpected message at a time

Signed-off-by: Sai Sunku <sunkusa@amazon.com>
It's better to query the device than to hardcode the limit in case the
limit changes in the future

Signed-off-by: Sai Sunku <sunkusa@amazon.com>
Signed-off-by: Sai Sunku <sunkusa@amazon.com>
@sunkuamzn
Copy link
Contributor Author

Fixed fabtest failures. CI passing now.

@a-szegel a-szegel merged commit 04ef302 into ofiwg:main Dec 29, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants