prov/efa: Reduce # of error cases in happy path #9680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch uses nested if cases to reduce the number of error checks in the fast happy path from 3 to 1 inside efa_rdm_pke_handle_rtm_rta_recv(). Signed-off-by: Seth Zegelstein <szegel@amazon.com>
wenduwan
approved these changes
Dec 28, 2023
shijin-aws
reviewed
Jan 3, 2024
| efa_rdm_pke_release_rx(pkt_entry); | ||
| return; | ||
| } | ||
| } else if (OFI_UNLIKELY(ret < 0)) { |
There was a problem hiding this comment.
no need to use else if, just if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses nested if cases to reduce the number of error checks in the fast happy path from 3 to 1 inside
efa_rdm_pke_handle_rtm_rta_recv(). It also cleans up some extra spacing in comments.