fix: match the id of select with for attr (#280)

Co-authored-by: “BogdanDanilescu” <bogdan.danilescu@nearform.com>
ogcio · Oct 10, 2024 · 44f5d0d · 44f5d0d
1 parent d5554d6
commit 44f5d0d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/html/ds/src/select/select.html b/packages/html/ds/src/select/select.html
@@ -41,7 +41,7 @@
       }}
     {% endif %}
     <select
-      id="{{ ariaLabel }}"
+      id="{{ props.id }}"
       aria-label="{{ ariaLabel }}"
       class="focus:gi-outline focus:gi-outline-[3px] focus:gi-outline-yellow-400 focus:gi-outline-offset-0 gi-p-1.5 gi-border-black gi-border-[3px] gi-border-solid gi-min-w-56 gi-font-primary xs:gi-text-sm md:gi-text-md lg:gi-text-lg {{ marginTop }}"
     >

diff --git a/packages/react/ds/src/select/select.tsx b/packages/react/ds/src/select/select.tsx
@@ -51,7 +51,7 @@ export function Select({ id, label, options, hint, error }: SelectProps) {
           xs:gi-text-sm
           md:gi-text-md
           lg:gi-text-lg"
-        id={ariaLabel}
+        id={id}
         aria-label={ariaLabel}
       >
         {options.map((option) => {