Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add html link component #184

Merged
merged 10 commits into from
Sep 2, 2024
Merged

feat: add html link component #184

merged 10 commits into from
Sep 2, 2024

Conversation

hamza14khan
Copy link
Collaborator

@hamza14khan hamza14khan commented Aug 28, 2024

  • Addition of html link component and macro.
  • Customisation options with external, noUnderline, dark and noVisited states.
  • Updated wagtail example with link usage.

TODOs:

  • Add custom class for 'text-decoration-skip-ink': 'none'.
  • Font smoothing adjustments on create theme font-smoothing: antialiased;

Storybook Testing
Screenshot 2024-08-30 at 16 33 51

Wagtail Example
Screenshot 2024-08-29 at 10 36 48

Copy link
Collaborator

@pregno pregno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a simple usage example in example/wagtail and example/nextjs?

@pregno
Copy link
Collaborator

pregno commented Aug 28, 2024

Could you add a simple usage example in example/wagtail and example/nextjs?

@hamza14khan example/nextjs uses React components, so you can probably skip for now

@hamza14khan hamza14khan merged commit f55baab into main Sep 2, 2024
1 check passed
@hamza14khan hamza14khan deleted the feat/link-component branch September 2, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants