Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: footer component #187

Merged
merged 27 commits into from
Sep 4, 2024
Merged

feat: footer component #187

merged 27 commits into from
Sep 4, 2024

Conversation

BogdanDanilescu
Copy link
Collaborator

@BogdanDanilescu BogdanDanilescu commented Sep 2, 2024 •
edited
Loading

  • Implementation of govieFooter component
  • It can accept the following props:
    links
    secondaryNavLinks

Storybook testing:
image

hamza14khan and others added 17 commits August 29, 2024 10:38
@hamza14khan
feat: add link component
b5d9d80
@hamza14khan
feat: update link component with additional storybook customisation
c7a3b8f
@hamza14khan
feat: add link test
648d430
@hamza14khan
feat: update wagtail example with link usage
04ace83
@hamza14khan
feat: update test files for build ts errors
1d0daa9
@BogdanDanilescu
add base footer global component
23ff508
@BogdanDanilescu
resolve macros import
94c19ec
@BogdanDanilescu
sync imports with html storybook and wagtail application
958dc84
@hamza14khan
feat: update color on hover and focus state
ec0e51c
@hamza14khan
feat: add dark background settings
ebff969
@hamza14khan
feat: add test for dark background and update default values
686d25f
@hamza14khan
feat: refactor function name
7b8244f
@hamza14khan
Merge branch 'main' into feat/link-component
2d96c60
@BogdanDanilescu
merge link branch
420c02d
@BogdanDanilescu
add stories, implement props in macro, modularise helpers
ba21a6b
@BogdanDanilescu
add description to schema, update macro type, add footer in wagtail
d337c61
@BogdanDanilescu
Merge branch 'main' of https://github.com/ogcio/govie-ds into impleme…
b3017cf 
…nt-footer-component
@BogdanDanilescu BogdanDanilescu marked this pull request as ready for review September 3, 2024 11:37
@hamza14khan hamza14khan changed the title Implement footer component feat: footer component Sep 3, 2024
@hamza14khan
Copy link
Collaborator

Can you please add screenshot for testing and maybe some description? Thanks! 🙏

hamza14khan
hamza14khan requested changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@hamza14khan hamza14khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on the footer component 👍

Added minor comments.

@hamza14khan hamza14khan added the enhancement New feature or request label Sep 4, 2024
@BogdanDanilescu BogdanDanilescu merged commit 49ad582 into main Sep 4, 2024
1 check passed
@BogdanDanilescu BogdanDanilescu deleted the implement-footer-component branch September 4, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza14khan hamza14khan hamza14khan approved these changes

@pregno pregno pregno approved these changes

Assignees

@BogdanDanilescu BogdanDanilescu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BogdanDanilescu @hamza14khan @pregno