Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update TextArea and TextInput with label, error and hint props #237

Merged
merged 12 commits into from
Sep 25, 2024
Merged

chore: update TextArea and TextInput with label, error and hint props #237

merged 12 commits into from
Sep 25, 2024

Conversation

hamza14khan
Copy link
Collaborator

Vite testing:
Screenshot 2024-09-24 at 17 18 41

Storybook props for textarea:
Screenshot 2024-09-24 at 17 28 01

Storybook props for textinput:
Screenshot 2024-09-24 at 17 15 13

@hamza14khan hamza14khan added the enhancement New feature or request label Sep 24, 2024
@hamza14khan hamza14khan self-assigned this Sep 24, 2024
@hamza14khan hamza14khan force-pushed the chore/update-textinput-and-textarea-props branch from 7674c8c to 0a68865 Compare September 24, 2024 16:45
@hamza14khan hamza14khan force-pushed the chore/update-textinput-and-textarea-props branch from 0a68865 to 2f20118 Compare September 25, 2024 11:42
BogdanDanilescu
BogdanDanilescu approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@BogdanDanilescu BogdanDanilescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great stuff on the components 👍

@hamza14khan hamza14khan force-pushed the chore/update-textinput-and-textarea-props branch from e956f55 to d74ac86 Compare September 25, 2024 13:45
@hamza14khan hamza14khan merged commit f094b91 into main Sep 25, 2024
6 of 10 checks passed
@hamza14khan hamza14khan deleted the chore/update-textinput-and-textarea-props branch September 25, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BogdanDanilescu BogdanDanilescu BogdanDanilescu approved these changes

@pregno pregno pregno approved these changes

Assignees

@hamza14khan hamza14khan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza14khan @pregno @BogdanDanilescu