Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor children prop #250

Merged
merged 2 commits into from
Oct 1, 2024
Merged

chore: refactor children prop #250

merged 2 commits into from
Oct 1, 2024

Conversation

BogdanDanilescu
Copy link
Collaborator

As part of 21977 I've refactored the children into a text prop so now it accepts string instead of a react node.

pregno
pregno approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@pregno pregno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hamza14khan
hamza14khan approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@hamza14khan hamza14khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this! 👍

@BogdanDanilescu BogdanDanilescu merged commit fd77425 into main Oct 1, 2024
7 of 8 checks passed
@BogdanDanilescu BogdanDanilescu deleted the chore/review-react-components-implementation branch October 1, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza14khan hamza14khan hamza14khan approved these changes

@pregno pregno pregno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BogdanDanilescu @pregno @hamza14khan