Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: radio component #279

Merged
merged 35 commits into from
Oct 15, 2024
Merged

feat: radio component #279

merged 35 commits into from
Oct 15, 2024

Conversation

BogdanDanilescu
Copy link
Collaborator

@BogdanDanilescu BogdanDanilescu commented Oct 10, 2024 •
edited
Loading

Implementation of the Radio component ( React & HTML )

PR for adding the Radio component for the HTML and React library.

  • add global CSS classes
  • add stories
  • add tests
  • add example in Wagtail, vite, nextjs
  • add documentation

props:

fieldId
inline
items
errorMessage
dividerOption
title
size

Stories
image
Screenshot 2024-10-10 at 11 45 30
Screenshot 2024-10-10 at 11 45 39
Screenshot 2024-10-10 at 11 45 49
Screenshot 2024-10-10 at 11 45 59
Screenshot 2024-10-10 at 11 46 07
Screenshot 2024-10-10 at 11 46 16

@BogdanDanilescu BogdanDanilescu added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 15, 2024
hamza14khan
hamza14khan approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@hamza14khan hamza14khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments but overall looks good.

@BogdanDanilescu BogdanDanilescu merged commit 1067f5c into main Oct 15, 2024
9 of 12 checks passed
@BogdanDanilescu BogdanDanilescu deleted the feat/HTML-radio-component branch October 15, 2024 10:52
@pregno pregno mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza14khan hamza14khan hamza14khan approved these changes

@pregno pregno pregno approved these changes

@ramonmulia ramonmulia ramonmulia approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BogdanDanilescu @ramonmulia @pregno @hamza14khan