Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: html toast component #335

Merged
merged 10 commits into from
Nov 22, 2024
Merged

feat: html toast component #335

merged 10 commits into from
Nov 22, 2024

Conversation

BogdanDanilescu
Copy link
Collaborator

PR to implement Toast for the macros

added:

  • stories
  • tests
  • schema
  • macro structure
  • js logic
  • docs

SB screenshots
Screenshot 2024-11-21 at 16 41 10
Screenshot 2024-11-21 at 16 41 36

ramonmulia
ramonmulia approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@ramonmulia ramonmulia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hamza14khan
hamza14khan approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@hamza14khan hamza14khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

pregno
pregno approved these changes Nov 22, 2024
View reviewed changes
packages/html/ds/styles.css Outdated Show resolved Hide resolved
@BogdanDanilescu BogdanDanilescu merged commit 0afc349 into main Nov 22, 2024
10 of 12 checks passed
@BogdanDanilescu BogdanDanilescu deleted the feat/html-toast-component branch November 22, 2024 14:32
@pregno pregno mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza14khan hamza14khan hamza14khan approved these changes

@pregno pregno pregno approved these changes

@ramonmulia ramonmulia ramonmulia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BogdanDanilescu @ramonmulia @pregno @hamza14khan