Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination consistent width across html and react platforms #337

Merged
merged 6 commits into from
Nov 26, 2024
Merged

fix: pagination consistent width across html and react platforms #337

merged 6 commits into from
Nov 26, 2024

Conversation

hamza14khan
Copy link
Collaborator

  • Pagination (react and html): usage icon classes on next and previous buttons if no label is shown (e.g. under 640px - small screens).
  • Extended class names on button macro.
  • Documentation update.

Testing:
Screenshot 2024-11-25 at 22 40 31

@hamza14khan hamza14khan added bug Something isn't working documentation Improvements or additions to documentation labels Nov 25, 2024
@hamza14khan hamza14khan self-assigned this Nov 25, 2024
@hamza14khan hamza14khan force-pushed the fix/pagination-compact-view-button branch from a6f72ab to 950bd0d Compare November 25, 2024 22:44
pregno
pregno approved these changes Nov 26, 2024
View reviewed changes
apps/docs/dictionary.txt Show resolved Hide resolved
@pregno pregno merged commit 0d8cef1 into main Nov 26, 2024
12 checks passed
@pregno pregno deleted the fix/pagination-compact-view-button branch November 26, 2024 16:51
@pregno pregno mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pregno pregno pregno approved these changes

@ramonmulia ramonmulia ramonmulia approved these changes

@BogdanDanilescu BogdanDanilescu Awaiting requested review from BogdanDanilescu

Assignees

@hamza14khan hamza14khan

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hamza14khan @ramonmulia @pregno