Feature: configure logging wrapper #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "eslint-plugin-prettier": "^5.1.3", | ||
| "jest": "^29.7.0", | ||
| "prettier": "^3.2.5", | ||
| "ts-jest": "^29.1.2", |
There was a problem hiding this comment.
Usually, we avoid Jest while testing Node.js applications in favour of other test frameworks (like TAP) due to some known issues.
There was a problem hiding this comment.
Ouch!
I've used that because we have explicit request of do that in our docs
Anyway, thank you, I will update tests and docs!
|
@SamSalvatico I like the approach! Would be cool to see some usage examples as well. Can you please add just a basic usage example? Feel free to use the |
SamSalvatico
requested review from
Thurfjell,
edge33,
nnorbert,
GiuliaTeggi and
peschina
GiuliaTeggi
reviewed
Apr 24, 2024
Thurfjell
previously requested changes
Apr 24, 2024
* feature(logging-wrapper): added tests helper * Added README for logging-wrapper * Added tap * Added gitignore * Tap config * Added tests for logging-wrapper.test.ts * Added fastify tests * Chore: Use logging-wrapper in payments-api (#160) * Updated wrapper to be built * Updated commands to build logging wrapper * Removed useless files * Payments api is using logging wrapper * Updated error response management * Updated version * Fixed logging wrapper tests * Updated packages * Copy logging wrapper in the dockerfile * Added error handling package * Added package script * Optional logging hooks * Removed logging hooks * Started working on error handling tests * Started working on error handling tests * Added tests for not found handler * Added logging hooks * Removed useless copy * Renamed to error-handler * Updated sdk definitions
|
@GiuliaTeggi @Thurfjell I've merged previous PRs on this, splitting concerns between |
GiuliaTeggi
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a logging wrapper for Fastify that would help us to standardize logs between services as requested in the API Design document
Type
Checklist:
A new PR with the test suite will follow really soon