Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): seed analytics sdk #134

Merged
merged 1 commit into from
Sep 13, 2024
Merged

feat(cli): seed analytics sdk #134

merged 1 commit into from
Sep 13, 2024

Conversation

alewin
Copy link

@alewin alewin commented Sep 11, 2024

Ticket:

Description

Add seed for analytics SDK logto integration
Related to: https://github.com/ogcio/life-events-terraform/pull/127

Type

  • Dependency upgrade
  • Bug fix
  • New feature
  • Dev change

Checklist:

  • I have added tests that prove my fix is effective or that my feature works

Screenshots:

N/A

@alewin alewin self-assigned this Sep 11, 2024
@alewin alewin force-pushed the feature/analytics-sdk-logto branch 4 times, most recently from 513fb82 to ea5ae80 Compare September 12, 2024 10:45
@alewin alewin marked this pull request as ready for review September 12, 2024 10:47
Copy link

@andreacappadona17 andreacappadona17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @edge33 could you please have a look at it, too?

Copy link
Collaborator

@SamSalvatico SamSalvatico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to also add it to ogcio-seeder-testing.json

@alewin
Copy link
Author

alewin commented Sep 13, 2024

You have to also add it to ogcio-seeder-testing.json

@SamSalvatico
I haven't added anything on testing voluntarily, also the already existing part of "analytics:mesurable" is currently not added on testing file, because i have not started testing it yet. but if it is mandatory I will add it and then modify it as needed in the future

@SamSalvatico
Copy link
Collaborator

SamSalvatico commented Sep 13, 2024 via email

@alewin alewin merged commit aeaf6fd into dev Sep 13, 2024
4 checks passed
@alewin alewin deleted the feature/analytics-sdk-logto branch September 13, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants