Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use port 7001 instead of 5001 to avoid conflicts with forms #56

Merged
merged 2 commits into from
Jul 2, 2024
Merged

chore: use port 7001 instead of 5001 to avoid conflicts with forms #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dc21a6
chore: use port 7001 instead of 5001 to avoid conflicts with forms
msebastianb Jul 2, 2024
4b7498c
chore: add ogcio comments
msebastianb Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitpod.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ ports:
port: 5432
visibility: public
onOpen: ignore
- port: 5001
# OGCIO - formsie port collision fixed
- port: 7001
onOpen: ignore
- port: 5002
onOpen: ignore
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/middleware/koa-spa-proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import serveStatic from '#src/middleware/koa-serve-static.js';
export default function koaSpaProxy<StateT, ContextT extends IRouterParamContext, ResponseBodyT>(
mountedApps: string[],
packagePath = 'experience',
port = 5001,
// OGCIO - formsie port collision fixed
port = 7001,
prefix = ''
): MiddlewareType<StateT, ContextT, ResponseBodyT> {
type Middleware = MiddlewareType<StateT, ContextT, ResponseBodyT>;
Expand Down
3 changes: 2 additions & 1 deletion packages/core/src/routes/applications/application.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,8 @@ const applicationRoutes = await pickDefault(import('./application.js'));
const customClientMetadata = {
corsAllowedOrigins: [
'http://localhost:5000',
'http://localhost:5001',
// OGCIO - formsie port collision fixed
'http://localhost:7001',
'https://silverhand.com',
'capacitor://localhost',
],
Expand Down
2 changes: 1 addition & 1 deletion packages/experience/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"scripts": {
"precommit": "lint-staged",
"start": "parcel src/index.html",
"dev": "cross-env PORT=5001 parcel src/index.html --no-cache --hmr-port 6001",
"dev": "cross-env PORT=7001 parcel src/index.html --no-cache --hmr-port 6001",
"check": "tsc --noEmit",
"build": "pnpm check && rm -rf dist && parcel build src/index.html --no-autoinstall --no-cache --detailed-report",
"lint": "eslint --ext .ts --ext .tsx src",
Expand Down