Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add storybook infrastructure #226

Closed
wants to merge 7 commits into from
Closed

Conversation

williamwd
Copy link

No description provided.

@williamwd
Copy link
Author

Necessary to address some concerns in the infrastructure code:

  • CI does not validate PRs
  • No security checks when merging code
  • Terragrunt stacks only work independently, no current way to run all modules within the pipeline
  • New modules must be added manually on the pipeline
  • Terragrunt might be too complex for such a simple infrastructure. To be discussed.

@ianlnf ianlnf changed the title [Infra] Add storybooks ci: add storybook infrastructure Aug 14, 2024
@ianlnf
Copy link
Contributor

ianlnf commented Aug 14, 2024

Closing as this infrastructure is related to govie-ds, rather than ogcio-ds. Would suggest that the infra code is managed in the building blocks terraform repo as S3 buckets in the short term, and reviewed as a switch to Docker if going on-prem in future.

@ianlnf ianlnf closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants