Merge pull request #339 from tdakkota/fix/content-path-paramater-panic

fix(gen): handle path parameters with unsupported content correctly

_testdata/positive/test_content_path_parameter.yml

@@ -0,0 +1,22 @@
+openapi: 3.0.0
+info:
+  title: Test schema
+  version: 0.1.0
+paths:
+  /{shortURL}:
+    get:
+      parameters:
+        - name: shortURL
+          in: path
+          required: true
+          content:
+            '*/*':
+              schema:
+                type: string
+      responses:
+        '200':
+          description: Response
+          content:
+            application/json:
+              schema:
+                type: string

gen/gen_parameters.go

@@ -14,10 +14,16 @@ func (g *Generator) generateParameters(ctx *genctx, opName string, params []*ope
 	result := make([]*ir.Parameter, 0, len(params))
 	for i, p := range params {
 		if p.Content != nil {
-			if err := g.fail(&ErrNotImplemented{"parameter content field"}); err != nil {
+			notImplemented := &ErrNotImplemented{"parameter content field"}
+			if err := g.fail(notImplemented); err != nil {
 				return nil, errors.Wrap(err, "fail")
 			}
 
+			// Path parameters are required.
+			if p.In == openapi.LocationPath {
+				return nil, notImplemented
+			}
+
 			continue
 		}
 

gen_test.go

@@ -4,6 +4,7 @@ import (
 	"embed"
 	"io/fs"
 	"path/filepath"
+	"runtime/debug"
 	"strings"
 	"testing"
 
@@ -33,7 +34,7 @@ func testGenerate(_ bool, name string, ignore ...string) func(t *testing.T) {
 		t.Run("Gen", func(t *testing.T) {
 			defer func() {
 				if rr := recover(); rr != nil {
-					t.Fatalf("panic: %+v", rr)
+					t.Fatalf("panic: %+v\n%s", rr, debug.Stack())
 				}
 			}()