Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): properly encode optional array parameter #1245

Merged
merged 3 commits into from
May 20, 2024

Conversation

tdakkota
Copy link
Member

Fixes #1233

@tdakkota tdakkota force-pushed the fix/respect-array-parameter-semantic branch from deca99e to dfdcdd7 Compare May 17, 2024 03:45
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (b1ddda2) to head (dfdcdd7).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files         189      189           
  Lines       12772    12772           
=======================================
  Hits         9435     9435           
+ Misses       2797     2796    -1     
- Partials      540      541    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernado ernado merged commit 4e6d58f into ogen-go:main May 20, 2024
14 checks passed
@tdakkota tdakkota deleted the fix/respect-array-parameter-semantic branch May 21, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect handling of empty optional UUID array header
2 participants