Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): add size to MultipartFile struct #1247

Merged
merged 2 commits into from
May 21, 2024

Conversation

ldmonster
Copy link
Contributor

If we parse Multipart File, we have a size in parsing result.
I think, we can send file size to user in multipart file struct, to use next.

Purpose:
When i work with min.io, i'm stuck with storage my object, because it want's file size to use different store algorithms.
So, i made this fix for myself.

Generators: OK
Tests: OK

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.87%. Comparing base (dfdcdd7) to head (fc23362).
Report is 1 commits behind head on main.

Current head fc23362 differs from pull request most recent head 06b65f9

Please upload reports for the commit 06b65f9 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1247   +/-   ##
=======================================
  Coverage   73.87%   73.87%           
=======================================
  Files         189      189           
  Lines       12772    12772           
=======================================
  Hits         9435     9435           
  Misses       2796     2796           
  Partials      541      541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tdakkota tdakkota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to conform ogen contributing guide.

Generated code changes should be in a separate commit.

Thanks.

@ldmonster ldmonster force-pushed the feature/add-size-to-multipart branch from fc23362 to 06b65f9 Compare May 21, 2024 07:20
@tdakkota tdakkota changed the title fix(gen): add size to MultipartFile struct feat(gen): add size to MultipartFile struct May 21, 2024
@tdakkota tdakkota enabled auto-merge May 21, 2024 08:16
@tdakkota tdakkota merged commit d3812bb into ogen-go:main May 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants