Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include Pattern when encountering NoRegexMatchError #1340

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

paragon
Copy link
Contributor

@paragon paragon commented Nov 7, 2024

This change includes the Regex when returning a NoRegexMatchError so clients have an easier time understanding any errors they encounter.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.47%. Comparing base (20a20b7) to head (44a0996).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
+ Coverage   71.44%   71.47%   +0.02%     
==========================================
  Files         190      190              
  Lines       15588    15590       +2     
==========================================
+ Hits        11137    11143       +6     
+ Misses       3898     3895       -3     
+ Partials      553      552       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paragon paragon force-pushed the feat-regex-match-error-pattern branch from c05f1a5 to 863955b Compare November 8, 2024 15:28
@paragon paragon changed the title feat: Include Pattern when encountering NoRegexMatchError feat: include Pattern when encountering NoRegexMatchError Nov 8, 2024
@paragon paragon force-pushed the feat-regex-match-error-pattern branch 2 times, most recently from 5bcce0f to db5758d Compare November 11, 2024 13:49
@tdakkota tdakkota merged commit 5c2592c into ogen-go:main Nov 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants