Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): discriminator inference by unique fields #151

Merged

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Feb 2, 2022

Fixes #150.

@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #151 (69925cd) into main (276b190) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   72.38%   72.38%           
=======================================
  Files          78       78           
  Lines        4838     4838           
=======================================
  Hits         3502     3502           
  Misses       1110     1110           
  Partials      226      226           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 276b190...69925cd. Read the comment docs.

@ernado ernado merged commit eb5784c into ogen-go:main Feb 2, 2022
@tdakkota tdakkota deleted the fix/incorrect-discriminator-inference branch February 2, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(gen): discriminator inference by unique fields is incorrect, if sum has one non-object type
2 participants