Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ir): do not panic, if generating postfix for Any type #187

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Feb 14, 2022

Prevent panic in boxing cases like "array of Any"

Prevent panic in boxing cases like "array of Any"
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #187 (51ef729) into main (ef7463c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
+ Coverage   67.94%   68.01%   +0.06%     
==========================================
  Files          99       99              
  Lines        6274     6275       +1     
==========================================
+ Hits         4263     4268       +5     
+ Misses       1762     1759       -3     
+ Partials      249      248       -1     
Impacted Files Coverage Δ
internal/ir/type.go 73.14% <100.00%> (+1.18%) ⬆️
gen/reduce.go 74.28% <0.00%> (+8.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7463c...51ef729. Read the comment docs.

@ernado ernado merged commit f917bb9 into ogen-go:main Feb 14, 2022
@tdakkota tdakkota deleted the fix/generate-postfix-for-array branch February 15, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants