Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add null type support #294

Merged
merged 5 commits into from
Apr 13, 2022
Merged

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #294 (44b4979) into main (71f311a) will increase coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   66.87%   66.91%   +0.03%     
==========================================
  Files         116      116              
  Lines        7696     7717      +21     
==========================================
+ Hits         5147     5164      +17     
- Misses       2207     2211       +4     
  Partials      342      342              
Impacted Files Coverage Δ
internal/ir/faker.go 0.00% <0.00%> (ø)
internal/ir/json.go 83.42% <0.00%> (-0.94%) ⬇️
jsonschema/schema.go 100.00% <ø> (ø)
gen/generics.go 53.12% <100.00%> (+2.57%) ⬆️
gen/schema_gen.go 78.21% <100.00%> (ø)
gen/schema_gen_primitive.go 88.23% <100.00%> (+0.30%) ⬆️
internal/ir/primitive.go 66.66% <100.00%> (+1.44%) ⬆️
internal/ir/template_helpers.go 74.41% <100.00%> (+0.60%) ⬆️
jsonschema/parser.go 80.87% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f311a...44b4979. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review April 13, 2022 12:29
@ernado ernado merged commit ce4b239 into ogen-go:main Apr 13, 2022
@tdakkota tdakkota deleted the feat/null-support branch April 13, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants