Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): allow sum types as type discriminator #300

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #300 (a9adcfa) into main (5610658) will decrease coverage by 0.03%.
The diff coverage is 68.18%.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   66.91%   66.87%   -0.04%     
==========================================
  Files         117      117              
  Lines        7785     7823      +38     
==========================================
+ Hits         5209     5232      +23     
- Misses       2227     2239      +12     
- Partials      349      352       +3     
Impacted Files Coverage Δ
gen/schema_gen_sum.go 81.96% <62.50%> (-2.99%) ⬇️
gen/ir/json.go 82.58% <75.00%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5610658...a9adcfa. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review April 19, 2022 18:00
@ernado ernado merged commit 48bbec4 into ogen-go:main Apr 20, 2022
@tdakkota tdakkota deleted the feat/handle-subsum branch April 20, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants