Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): add string integers support #313

Merged
merged 6 commits into from
Apr 26, 2022

Conversation

tdakkota
Copy link
Member

Fixes #309

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #313 (9fb3d29) into main (6916daf) will increase coverage by 0.34%.
The diff coverage is 94.36%.

@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   67.42%   67.77%   +0.34%     
==========================================
  Files         117      118       +1     
  Lines        7887     7953      +66     
==========================================
+ Hits         5318     5390      +72     
+ Misses       2228     2224       -4     
+ Partials      341      339       -2     
Impacted Files Coverage Δ
gen/schema_gen_sum.go 83.53% <0.00%> (ø)
gen/ir/json.go 83.25% <72.72%> (-0.83%) ⬇️
gen/ir/type.go 78.12% <100.00%> (+1.45%) ⬆️
gen/schema_gen_primitive.go 88.61% <100.00%> (+0.38%) ⬆️
json/int.go 100.00% <100.00%> (ø)
jsonschema/parser.go 81.84% <0.00%> (+1.91%) ⬆️
openapi/parser/parse_components.go 100.00% <0.00%> (+8.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6916daf...9fb3d29. Read the comment docs.

@ernado ernado merged commit af4b1c5 into ogen-go:main Apr 26, 2022
@tdakkota tdakkota deleted the feat/add-string-integers branch April 26, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support string integers
2 participants