Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): disallow non-numeric enum with format #331

Merged
merged 3 commits into from
May 2, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented May 2, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #331 (58b111a) into main (41863c9) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
- Coverage   67.97%   67.95%   -0.03%     
==========================================
  Files         119      119              
  Lines        8023     8026       +3     
==========================================
  Hits         5454     5454              
- Misses       2228     2230       +2     
- Partials      341      342       +1     
Impacted Files Coverage Δ
gen/schema_gen_primitive.go 89.39% <100.00%> (+0.24%) ⬆️
openapi/parser/parse_components.go 91.89% <0.00%> (-8.11%) ⬇️
jsonschema/parser.go 80.12% <0.00%> (-1.90%) ⬇️
gen/schema_gen.go 81.73% <0.00%> (+1.44%) ⬆️
gen/reduce.go 74.28% <0.00%> (+8.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41863c9...58b111a. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review May 2, 2022 18:56
@ernado ernado merged commit 0593fbb into ogen-go:main May 2, 2022
@tdakkota tdakkota deleted the fix/disallow-format-enum branch May 2, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants