Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows an extra space after XML icon in --long listings #891

Closed
ricpelo opened this issue Jun 19, 2021 · 4 comments · Fixed by #1013
Closed

Shows an extra space after XML icon in --long listings #891

ricpelo opened this issue Jun 19, 2021 · 4 comments · Fixed by #1013
Labels
features › ui Things to do with the UI

Comments

@ricpelo
Copy link
Contributor

ricpelo commented Jun 19, 2021

Exa shows an extra space after XML icon in --long listings:

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=20.04
DISTRIB_CODENAME=focal
DISTRIB_DESCRIPTION="Ubuntu 20.04.2 LTS"
$ exa --version
exa - list files on the command-line
v0.10.1 [+git]
https://the.exa.website/
$ exa --icons --long *.xml *.py

2021-06-19-105249_1189x279_scrot

@ariasuni
Copy link
Collaborator

Can confirm with several terminal emulators: Konsole and Kitty, Arch Linux, nerd-fonts-hack 2.1.0 (latest).

It seems that the XML icon (U+FABF) is displayed with a larger width, resulting visually in a additional space. I don’t think it’s supposed to work like that, it will need further investigation.

@ariasuni ariasuni added errors › invalid output exa didn’t crash but was incorrect features › ui Things to do with the UI and removed errors › invalid output exa didn’t crash but was incorrect labels Jun 22, 2021
@ariasuni
Copy link
Collaborator

I opened a bug report on Nerd Fonts’ end, it would to nice if you could add your setup info there:
ryanoasis/nerd-fonts#637

@ricpelo
Copy link
Contributor Author

ricpelo commented Jan 12, 2022

Interestingly, I've recently realized Exa sometimes uses another slightly different icon, but without the extra-space problem.

I attach an screenshot to illustrate.
2022-01-12-223848_967x381_scrot

The icon near lib directory shows OK, and it's not exactly the same icon used in the .xml files.

Maybe Exa should use the working icon everywhere?

ricpelo added a commit to ricpelo/exa that referenced this issue Jan 23, 2022
ariasuni added a commit that referenced this issue Mar 17, 2022
Uses same icon for lib, xml & xul files (fix #891)
@ariasuni
Copy link
Collaborator

It’s fixed! Yeah, some icons in Nerd Fonts are replacing actual characters defined in Unicode which are considered as having a different size, but I’m not sure if we can do that for every problematic characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
features › ui Things to do with the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants