Improve TZ environment variable handling and use TZDIR #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ariasuni
force-pushed
the
fix-and-improve-getting-timezone
branch
from
33ba1b2
to
9650c21
Compare
ariasuni
force-pushed
the
fix-and-improve-getting-timezone
branch
from
9650c21
to
f2ef05f
Compare
This was referenced Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #856
Investigation will be needed to know if it fix the problem for Bedrock Linux (#712).
I bumped the Rust version from 1.42 to 1.45 to be able to usestrip_prefix.Edit: I rebased after #854 was merged.
If something goes wrong, exa fallbacks to UTC without any error message like it does for software using glibc or musl directly, but it still provides useful information when using
EXA_DEBUG.If it looks good to you, I’d like to add tests to this PR.