Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add postgres-js adapter #398

Conversation

smcclure17
Copy link

@smcclure17 smcclure17 commented Apr 11, 2024

From #386

In src/adapters/adapters.ts: Creates an adapter that mimics the contract/behavior of postgres-js similar to what is done for pg-native.

In src/tests/postgres-js-mimic.spec.ts: Adds tests to verify mimicked behavior matched original.

This only implements the default Sql template tagged literal and unsafe() for performing queries.. We would need to add further implementation to match the features from https://github.com/porsager/postgres

@smcclure17 smcclure17 marked this pull request as draft April 11, 2024 18:04
@smcclure17 smcclure17 changed the title WIP: Add postgres-js adapter feat: add postgres-js adapter Apr 11, 2024
@oguimbal
Copy link
Owner

oguimbal commented Aug 6, 2024

Hi there !

Thanks for this attempt :)

I however implemented a real way to hook postgres.js, see #411

@oguimbal oguimbal closed this Aug 6, 2024
@smcclure17
Copy link
Author

Wow, very nice!

Thanks for taking the time to implement this (especially with how tricky it is!) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants