Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the bug that the expression
42-51
fails to parse, because the tokenizer greedily treats-51
as being a number token.Closes #133
How
Move the lexer definitions for
int
andfloat
to be below theop_minus
definition. This changes the precedence so that the lexer emits a unary minus followed by an integer, rather than emitting a single negative-integer token.Update tests in
src/lexer.spec.ts
to expect this.Update tests in
src/syntax/expr.spec.ts
to expect the resulting wrapping of integer literals withtype: unary
AST nodes. In particular, replace the incorrect assertioncheckInvalidExpr('42.-51');
with one expecting abinary
AST node because that expression is valid.Change the parser definitions
expr_member
andsimplestatements_set_timezone_val
to parse the unary-followed-by-integer token sequence as a negative integer, as that is the only thing that makes sense in those expressions, and it limits the footprint of the change.