omf update: Report up-to-date packages as such #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| echo (omf::em)"$name successfully updated."(omf::off) | ||
| return 0 | ||
| case 1 | ||
| echo (omf::err)"Could not update $name."(omf::off) 1>&2 |
There was a problem hiding this comment.
let's just return 1 here rather than letting it fall back to the one at the bottom. it'll make it more clear.
|
I'm 👍 to merge this (whether or not we do the return I mentioned above). |
|
👍 |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this proposal is to generate a more accurate output on omf update. Namely, packages which have no upstream changes now report that they are already up to date.
Since this is a proposal we haven't really discussed before, this is broken into 3 commits (instead of squashed), so it's easier to track the changes and their aims.
Regarding performance, I must admit that I did not time the new code or the old.
Overall the update process should not improve and not deteriorate in terms of performance. The previous git pull is broken apart to a fetch and a merge. Packages without changes skip the merge (and possibly stashing) in return for an additional check. Packages with changes pay just one more check. If git does any more optimizations in combining the fetch and merge when running pull, I am unaware of such and I would appreciate any tips.