Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PB datetime tests. #125

Closed
wants to merge 8 commits into from

Conversation

DanielAvdar
Copy link
Contributor

Please note that the tests currently only cover date-time formats with the full year. Formats with only the last two year digits are excluded due to inconsistencies in the results returned by the pandas function .dt.strftime().

Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
Signed-off-by: DanielAvdar <66269169+DanielAvdar@users.noreply.github.com>
@DanielAvdar
Copy link
Contributor Author

Please note that the tests currently only cover date-time formats with the full year. Formats with only the last two year digits are excluded due to inconsistencies in the results returned by the pandas function .dt.strftime().

Fixed: This format can be cast to str only if the year is above 1900.

@DanielAvdar DanielAvdar requested a review from ohadmata February 25, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants